Skip to content

Implement new prim exec logic using motion controllers#3760

Draft
nycrat wants to merge 19 commits into
masterfrom
avah/prim_exec_motion_controller
Draft

Implement new prim exec logic using motion controllers#3760
nycrat wants to merge 19 commits into
masterfrom
avah/prim_exec_motion_controller

Conversation

@nycrat
Copy link
Copy Markdown
Member

@nycrat nycrat commented Jun 4, 2026

Description

Caution

This PR currently breaks simulated gameplay tests because the simulated movement is not the same anymore. PID constants need to be tuned, or the old velocity dampening needs to be reintegrated.

This is was a stacked PR: #3756 #3758 #3759 #3760.

This PR implements the new primitive executor logic, specifically:

  • When being sent a new move primitive, checks to see trajectory destination is different before switching to it.
  • Uses position/orientation controllers (which themselves use pid) to get the target linear/angular velocity

There are some necessary changes in this PR that are not in prim exec:

  • New hasSameDestination() method for trajectory classes
  • Extra param to generate trajectory with a new start point / start angle
  • Bugfix where erforce simulator passes in non-inverted worlds to yellow team primitive executors (supposed to be inverted)

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat changed the base branch from avah/prim_exec_update_state to master June 5, 2026 04:49
@nycrat nycrat marked this pull request as draft June 5, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant